fix KMSMasterKeyProvider to determine the default region before trying to create the requested master keys #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to create the requested master keys
karlw00t
reviewed
Sep 14, 2018
| @@ -25,6 +25,13 @@ | |||
| pytestmark = [pytest.mark.unit, pytest.mark.local] | |||
|
|
|||
|
|
|||
| def test_init_with_regionless_key_ids_and_region_names(): | |||
| key_ids = ("alias/key_1",) | |||
| region_names = ("test-reqion-1",) | |||
karlw00t
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #83
Description of changes:
Fix KMSMasterKeyProvider to determine the default region before trying to create the requested master keys.
We were previously trying to build the master keys before finding the default region, which would break any time a requested key ID was not a full Arn.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.