Properly handle negative values to _EncryptionStream.read() #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnwalker
approved these changes
Nov 8, 2018
| @@ -209,6 +209,10 @@ def read(self, b=None): | |||
| :returns: Processed (encrypted or decrypted) bytes from source stream | |||
| :rtype: bytes | |||
| """ | |||
| # Any negative value for b is interpreted as a full read | |||
There was a problem hiding this comment.
A full read means "read the entire message", and is triggered when either the number of bytes is not specified or when a negative value is specified.
This was referenced Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #26
Description of changes:
The actual fix was tiny. Most of this PR is refactoring the test class from unittest to pytest.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.