CI Adjustment #482
Merged
CI Adjustment #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes without converting the int
…ng using wrong path in CI
…set is coming from
…Device Advisor can clean up correctly, and hopefully fix Fleet-Provisioning CI
…mple when running in CI
…cure tunnel sample in CI
…date sample README
bretambrose
reviewed
Sep 29, 2022
| @@ -16,10 +16,6 @@ phases: | |||
| - echo Build started on `date` | |||
| - $CODEBUILD_SRC_DIR/codebuild/samples/setup-linux.sh | |||
| - $CODEBUILD_SRC_DIR/codebuild/samples/pubsub-linux.sh | |||
| - $CODEBUILD_SRC_DIR/codebuild/samples/connect-websocket-linux.sh | |||
There was a problem hiding this comment.
Do we need codebuild at all anymore?
There was a problem hiding this comment.
We do not need it for running samples, but there are webhooks for running Codebuild that we cannot remove without removing it for the entire repository. I also need to look at migrating Codebuild as well in the future, so I'm leaving just the PubSub Codebuild for that step in the migration.
bretambrose
approved these changes
Oct 5, 2022
|
Thanks! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adjusts how CI runs so it uses OpenID. Also fixes a few samples, adjusts the README for the samples so the policies shown are minimal and working in all cases, and adds a GitHub action that runs all samples, including Shadow, Jobs, Fleet Provisioning, Device Defender, and Secure Tunneling.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.