-
Notifications
You must be signed in to change notification settings - Fork 111
Secure Tunnel V2 WebSocket Protocol support #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some trivial suggestions.
The only concern I have was about how was the callback get handled during destruction. Other than that, the PR looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked through the documentation and sample README, but it looks good. I just had a few nitpicks but they are extremely minor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.