Skip to content

Secure Tunnel V2 WebSocket Protocol support #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Feb 23, 2023
Merged

Conversation

sbSteveK
Copy link
Contributor

  • Refactor Secure Tunnel to use new Secure Tunnel API.
  • V2WebSocketProtocol support for Secure Tunnel.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@xiazhvera xiazhvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some trivial suggestions.
The only concern I have was about how was the callback get handled during destruction. Other than that, the PR looks good to me.

Copy link
Contributor

@TwistedTwigleg TwistedTwigleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked through the documentation and sample README, but it looks good. I just had a few nitpicks but they are extremely minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants