Skip to content

optional tls settings on secure tunnel creation #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

sbSteveK
Copy link
Contributor

  • Add option to provide tls options when building a new secure tunnel

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@xiazhvera xiazhvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me, while I feel we should document that if the tlsOptions is set manually, then the root_ca configuration will be overwritten.

@sbSteveK sbSteveK marked this pull request as ready for review April 19, 2023 21:17
@sbSteveK sbSteveK merged commit fab025e into secure-tunnel-v3 Apr 19, 2023
@sbSteveK sbSteveK deleted the secure-tunnel-v3-tls branch April 19, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants