Build dependency missing from aws-iot-device-sdk-cpp-v2

[Kevin-Tacheny]

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[JonathanHenson]

This should be getting exported by aws-crt-cpp and not exposed outside of that. So if it’s not being picked up, we need to fix it there.

[Kevin-Tacheny]

I agree, this really was a temp did for us to move forward. Get Outlook for Android<https://aka.ms/ghei36>

________________________________ From: Jonathan M. Henson <[email protected]> Sent: Friday, March 1, 2019 12:17:43 PM To: awslabs/aws-iot-device-sdk-cpp-v2 Cc: Kevin Tacheny; Author Subject: Re: [awslabs/aws-iot-device-sdk-cpp-v2] Build dependency missing from aws-iot-device-sdk-cpp-v2 (#7) ***** EXTERNAL EMAIL ***** @JonathanHenson requested changes on this pull request.

________________________________ In CMakeLists.txt<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fawslabs%2Faws-iot-device-sdk-cpp-v2%2Fpull%2F7%23discussion_r261686843&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cadd9687f88404cc1816008d69e69d12a%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=T%2BU3kiIGOlLvxQJdkEmnZzFU%2Fnu3XHCHBTgvUw91zjQ%3D&reserved=0>:

@@ -15,6 +15,7 @@ endif()

set(IS_SUBDIRECTORY_INCLUDE true) find_package(aws-crt-cpp REQUIRED) +find_package(aws-c-cal REQUIRED) This should be getting exported by aws-crt-cpp and not exposed outside of that. So if it’s not being picked up, we need to fix it there. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fawslabs%2Faws-iot-device-sdk-cpp-v2%2Fpull%2F7%23pullrequestreview-209692735&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cadd9687f88404cc1816008d69e69d12a%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=Sah8cA2BUUhiNcyK%2BqPl7u%2BfGrbHyEtKV%2BeJt%2BSe4xI%3D&reserved=0>, or mute the thread<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAtkzmjje3Cf0WxJNz1la-eV83e6ecqAmks5vSWC3gaJpZM4bZOOG&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cadd9687f88404cc1816008d69e69d12a%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=8q0GtYNbwP6%2FGph6JUBYEF183c5gI8t7fOkwNcvdVkE%3D&reserved=0>.

[JonathanHenson]

now I'm actually confused. The HEAD of aws-crt-cpp already exports aws-c-cal. Were you just finding this error on the tag we recommended?

[Kevin-Tacheny]

Yes there is some sort of issue that causes aws-c-cal to not get picked up by the linker (from the v2 build). I found the issue on the master of the v2 repository. (at least when using the visual studio cmake feature). Best Regards, Kevin Tacheny From: Jonathan M. Henson <[email protected]> Sent: Monday, March 4, 2019 7:28 PM To: awslabs/aws-iot-device-sdk-cpp-v2 <[email protected]> Cc: Kevin Tacheny <[email protected]>; Author <[email protected]> Subject: Re: [awslabs/aws-iot-device-sdk-cpp-v2] Build dependency missing from aws-iot-device-sdk-cpp-v2 (#7) ***** EXTERNAL EMAIL ***** now I'm actually confused. The HEAD of aws-crt-cpp already exports aws-c-cal. Were you just finding this error on the tag we recommended? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fawslabs%2Faws-iot-device-sdk-cpp-v2%2Fpull%2F7%23issuecomment-469483365&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cfde6f29718c14fcf607208d6a1015abf%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=TA1ZTN74mtuj5rjamS7mKrTGPH2cMYfd7Masna0NlLE%3D&reserved=0>, or mute the thread<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAtkzmpBdpDaB3a36nkkxJM9Qbmndnuysks5vTbnygaJpZM4bZOOG&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cfde6f29718c14fcf607208d6a1015abf%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=xMLQr%2BVp75o10DKmXF4dv6SCi%2Fnf5XkEP2f7ONUMAhM%3D&reserved=0>.

[Kevin-Tacheny]

Here is the failure when building v2: As I am new to CMake I don't know how this should be fixed and/or where. My explicit inclusion of aws-c-cal was so we could move forward.

cmake -DCMAKE_INSTALL_PREFIX=/projects/out -DCMAKE_PREFIX_PATH=/projects/out -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Debug ../ -- The CXX compiler identification is GNU 6.3.0 -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found LibCrypto: /usr/lib/arm-linux-gnueabihf/libcrypto.so -- Libcrypto Include Dir: /usr/include -- Configuring done CMake Error at jobs/CMakeLists.txt:42 (add_library): Target "IotJobs-cpp" links to target "AWS::aws-c-cal" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at shadow/CMakeLists.txt:42 (add_library): Target "IotShadow-cpp" links to target "AWS::aws-c-cal" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at samples/jobs/describe_job_execution/CMakeLists.txt:10 (add_executable): Target "describe-job-execution" links to target "AWS::aws-c-cal" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at samples/shadow/shadow_sync/CMakeLists.txt:10 (add_executable): Target "shadow-sync" links to target "AWS::aws-c-cal" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at jobs/CMakeLists.txt:42 (add_library): Target "IotJobs-cpp" links to target "AWS::aws-c-cal" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at shadow/CMakeLists.txt:42 (add_library): Target "IotShadow-cpp" links to target "AWS::aws-c-cal" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?

[justinboswell]

The above linked PR, which is now merged to master, should resolve the issues in this PR. If not, please open an issue ticket.