Request response workspace pre format #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
reviewed
Nov 8, 2024
|
I couldn't find CI job where new tests are not skipped. Not sure if it's intentional or not. |
Not intentional and doesn't exist. Will fix. |
This reverts commit 634aea8.
…ssary. Skip tests on BYO_CRYPTO
sfod
approved these changes
Nov 15, 2024
xiazhvera
reviewed
Apr 8, 2025
| std::move(result), handler, responsePathTopicAccepted, responsePathTopicRejected); | ||
| }; | ||
|
|
||
| int submitResult = m_bindingClient->SubmitRequest(options, std::move(resultHandler)); |
There was a problem hiding this comment.
Just realize that we didn't bind aws_mqtt_request_operation_options. Why we are using the c type here?
There was a problem hiding this comment.
The usage is completely internal, so it's unclear what value binding it would add.
There was a problem hiding this comment.
It's not a big deal. It is just a little annoying to see a combination of crt-cpp and native object. > <
sfod
reviewed
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a request-response client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.