Skip to content

Fix shadow samples in CI #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Fix shadow samples in CI #780

merged 3 commits into from
Feb 21, 2025

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Feb 21, 2025

Issue #, if available:

When multiple instances of shadow samples are running in CI, they use the same thing and interfere with each other causing crashes:

Received shadow document.
Shadow contains "color". Updating local value to "Shadow_Value_0"...

stderr:
terminate called after throwing an instance of 'std::future_error'
  what():  std::future_error: Promise already satisfied

Description of changes:

Handle multiple incoming shadow messages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to delete these.

@sfod sfod merged commit e57bd3c into main Feb 21, 2025
39 of 40 checks passed
@sfod sfod deleted the fix-shadow-sample branch February 21, 2025 17:24
sfod added a commit that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants