Skip to content

Add subscription manager for MQTT #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Aug 11, 2020
Merged

Add subscription manager for MQTT #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
da4e531
Add files for a subscription manager module
aggarw13 Aug 4, 2020
4c38e3d
Minor changes
aggarw13 Aug 4, 2020
21b0ec2
Update demos/lexicon.txt for parameter names in subscription manager
aggarw13 Aug 4, 2020
0e4322f
Add another parameter list to lexicon file
aggarw13 Aug 4, 2020
68d0cde
Fix subscription manager to not match topics for empty record entries
aggarw13 Aug 5, 2020
430afeb
Address review comments
aggarw13 Aug 5, 2020
aac92f1
Improve topic matching logic and documentation
aggarw13 Aug 6, 2020
8d08d2c
Fix typos in header file
aggarw13 Aug 6, 2020
6b53e18
Address review comments
aggarw13 Aug 6, 2020
0d637fb
Merge branch 'add-subscription-manager' of github.com:aggarw13/aws-io…
aggarw13 Aug 6, 2020
157580a
wasn't -> was not to avoid the wrath of the spell checker
aggarw13 Aug 6, 2020
c4a2162
Merge branch 'development' into add-subscription-manager
aggarw13 Aug 6, 2020
85626a6
Changes to API documentation based on review comments
aggarw13 Aug 7, 2020
b75cc4a
Improvements in topic matching for correctness, readability and expre…
aggarw13 Aug 7, 2020
cda35d7
Add doc explanation for name index decrement in matchWildcards function
aggarw13 Aug 7, 2020
6541697
Add "sys" to demos/lexicon.txt to fix spell check
aggarw13 Aug 7, 2020
edaa2d2
Improvements to implementation of RegisterCallback and RemoveCallback…
aggarw13 Aug 7, 2020
ceb0d44
Fix bug in RegisterCallback function
aggarw13 Aug 7, 2020
e72c706
Add separate line comment add the end of the source file
aggarw13 Aug 7, 2020
6e42571
Minor fix in API doc
aggarw13 Aug 7, 2020
90ccdba
Merge branch 'development' of github.com:aws/aws-iot-device-sdk-embed…
aggarw13 Aug 10, 2020
b35b815
Remove merge conflict related text
aggarw13 Aug 10, 2020
bbc1ed2
Remove unnecessary extra parentheses in else-if expression
aggarw13 Aug 10, 2020
396b5ba
Minor hygiene in matchTopic function
aggarw13 Aug 10, 2020
9b4bd7f
Merge branch 'add-subscription-manager' of github.com:aggarw13/aws-io…
aggarw13 Aug 10, 2020
750d61e
Remove extra parentheses from matchTopic function
aggarw13 Aug 10, 2020
902ef2c
Merge branch 'development' into add-subscription-manager
aggarw13 Aug 10, 2020
b60ef01
More hygiene improvements for doc and code style
aggarw13 Aug 11, 2020
00b14af
Merge branch 'add-subscription-manager' of github.com:aggarw13/aws-io…
aggarw13 Aug 11, 2020
f4d07df
Fix typo
aggarw13 Aug 11, 2020
b56e984
Minor further doc improvements
aggarw13 Aug 11, 2020
3b1b7ec
Merge branch 'development' into add-subscription-manager
aggarw13 Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions demos/lexicon.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ developerguide
doesn
dup
endif
filterindex
hashmap
hasn
html
Expand All @@ -48,6 +49,7 @@ methodlen
milli
mosquitto
mqtt
nameindex
noninfringement
openssl
org
Expand All @@ -58,6 +60,7 @@ packetidtoresend
param
pathlen
pbuffer
pcontext
pdeserializedinfo
pem
pfixedbuffer
Expand All @@ -66,8 +69,10 @@ pindex
pingreq
pingresp
plaintext
pmatch
pmethod
pmqttcontext
pnameindex
pnetworkcontext
posix
ppacketinfo
Expand All @@ -76,6 +81,8 @@ ppubinfo
ppublishinfo
processloop
psessionpresent
ptopicfilter
ptopicname
ptransportinterface
puback
pubcomp
Expand All @@ -91,9 +98,12 @@ structs
suback
sublicense
subscribepublishloop
sys
tcp
tcpsocket
tls
topicfilterlength
topicnamelength
transportinterface
transporttimeout
uint
Expand Down
17 changes: 17 additions & 0 deletions demos/mqtt/subscription-manager/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
set( LIBRARY_NAME "mqtt_subscription_manager" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be called DEMO_NAME.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being added as a library instead of a demo binary so that multiple demos can call it (and thereby, link against it)

# Library target.
add_library( ${LIBRARY_NAME}
"${LIBRARY_NAME}.c" )

target_link_libraries(
${LIBRARY_NAME}
PRIVATE
mqtt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that Subscription manager links to MQTT? Should be other way round?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mqtt library does not have any dependency on the subscription manager, but subscription manager depends on the mqtt for its types like MQTTPublishInfo_t.
Practically, only a header dependency on mqtt exists for the subscription manager; so a linking dependency is not strictly required. (I can remove this linking dependency if you think that will be better, but the header include path dependency would definitely remain)

)

target_include_directories(
${LIBRARY_NAME}
PUBLIC
${LOGGING_INCLUDE_DIRS}
)

Loading