-
Notifications
You must be signed in to change notification settings - Fork 641
Use MQTT_PublishToResend() in the basic_tls and mutual_auth demos #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1101 +/- ##
===============================================
+ Coverage 96.54% 98.31% +1.77%
===============================================
Files 9 4 -5
Lines 5643 1189 -4454
Branches 641 369 -272
===============================================
- Hits 5448 1169 -4279
+ Misses 9 0 -9
+ Partials 186 20 -166
Continue to review full report at Codecov.
|
@@ -51,6 +51,7 @@ | |||
|
|||
/* MQTT API header. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally concerned that the use of MQTT_PublishToResend
seems superfluous when the outgoingPublishPackets
array already does the same work of maintaining PUBLISHes for resending?
We probably should show MQTT_PublishToResend
in a way that makes its utility more meaningful as the only way of storing PUBLISH packet ID order; otherwise, the use of the utility carries no need for the customer...
Initialize packetIdTo resend to the invalid one. Co-authored-by: Archit Aggarwal <[email protected]>
Update 0 to MQTT_PACKET_ID_INVALID Co-authored-by: Archit Aggarwal <[email protected]>
What do you suggest? My understanding is that the application must still own their publish packets and associate them packet IDs. |
I spoke with @leegeth separately, and after some thinking through, we realized that the |
…s#1101) MQTT_PublishToResend() is now used in the mqtt_basic_tls_demo and the mqtt_mutual_auth_demo because it preserves the ordering of MQTT publish messages. These demos use a Qos > 0. Updated the README.md in tools/spell for clarity on how to use the scripts.
…s#1101) MQTT_PublishToResend() is now used in the mqtt_basic_tls_demo and the mqtt_mutual_auth_demo because it preserves the ordering of MQTT publish messages. These demos use a Qos > 0. Updated the README.md in tools/spell for clarity on how to use the scripts.
…s#1101) MQTT_PublishToResend() is now used in the mqtt_basic_tls_demo and the mqtt_mutual_auth_demo because it preserves the ordering of MQTT publish messages. These demos use a Qos > 0. Updated the README.md in tools/spell for clarity on how to use the scripts.
…s#1101) MQTT_PublishToResend() is now used in the mqtt_basic_tls_demo and the mqtt_mutual_auth_demo because it preserves the ordering of MQTT publish messages. These demos use a Qos > 0. Updated the README.md in tools/spell for clarity on how to use the scripts.
Description of changes:
For demonstration purposes MQTT_PublishToResend() is now used in the mqtt_basic_tls_demo and the mqtt_mutual_auth_demo. These demos use a Qos > 0.
Extra changes:
Updated the README.md in tools/spell for clarity on how to use the scripts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.