Add remaining unit test coverage from CBMC changes to HTTP library #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1116 +/- ##
===============================================
+ Coverage 96.54% 98.85% +2.31%
===============================================
Files 9 4 -5
Lines 5643 1312 -4331
Branches 641 391 -250
===============================================
- Hits 5448 1297 -4151
+ Misses 9 0 -9
+ Partials 186 15 -171
Continue to review full report at Codecov.
|
sarenameas
approved these changes
Aug 12, 2020
aggarg
approved these changes
Aug 13, 2020
| TEST_ASSERT_EQUAL( HTTP_INSUFFICIENT_MEMORY, retCode ); | ||
|
|
||
| /* Length of headers > length of buffer.*/ | ||
| tearDown(); |
There was a problem hiding this comment.
Explicit call to teardown is probably an indication that these should be separate tests. Though this PR is not introducing it, so approving it.
yourslab
added a commit
to yourslab/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 17, 2020
…ws#1116) * Remove extra wrapping parenthesis * Add remaining coverage for HTTPClient_Send and its private methods * Add remaining coverage for HTTPClient_AddRangeHeader
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 27, 2020
…ws#1116) * Remove extra wrapping parenthesis * Add remaining coverage for HTTPClient_Send and its private methods * Add remaining coverage for HTTPClient_AddRangeHeader
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 28, 2020
…ws#1116) * Remove extra wrapping parenthesis * Add remaining coverage for HTTPClient_Send and its private methods * Add remaining coverage for HTTPClient_AddRangeHeader
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 31, 2020
…ws#1116) * Remove extra wrapping parenthesis * Add remaining coverage for HTTPClient_Send and its private methods * Add remaining coverage for HTTPClient_AddRangeHeader
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Sep 1, 2020
…ws#1116) * Remove extra wrapping parenthesis * Add remaining coverage for HTTPClient_Send and its private methods * Add remaining coverage for HTTPClient_AddRangeHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests for HTTPClient_Send and HTTPClient_ReadHeader
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.