Skip to content

Conversation

yourslab
Copy link
Contributor

This catches the corner case where the user has not passed a CMake flag but the absolute path logic is still applied.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yourslab yourslab requested a review from aggarw13 August 14, 2020 17:16
@codecov-commenter
Copy link

Codecov Report

Merging #1127 into development will increase coverage by 2.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1127      +/-   ##
===============================================
+ Coverage        96.54%   98.85%   +2.30%     
===============================================
  Files                9        4       -5     
  Lines             5643     1309    -4334     
  Branches           641      393     -248     
===============================================
- Hits              5448     1294    -4154     
+ Misses               9        0       -9     
+ Partials           186       15     -171     
Impacted Files Coverage Δ
libraries/standard/mqtt/src/mqtt.c 99.48% <ø> (+5.06%) ⬆️
libraries/standard/mqtt/src/mqtt_lightweight.c 97.42% <ø> (+2.90%) ⬆️
libraries/standard/mqtt/src/mqtt_state.c 98.46% <ø> (+2.52%) ⬆️
libraries/standard/http/src/http_client.c 100.00% <100.00%> (+12.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0fb37...846bd79. Read the comment docs.

@yourslab yourslab requested a review from aggarg August 14, 2020 17:17
@yourslab yourslab merged commit b9d22d8 into aws:development Aug 14, 2020
yourslab added a commit to yourslab/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 17, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 27, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 28, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 31, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants