Hygiene changes in demo configuration #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1136 +/- ##
===============================================
+ Coverage 96.54% 98.85% +2.30%
===============================================
Files 9 4 -5
Lines 5643 1309 -4334
Branches 641 393 -248
===============================================
- Hits 5448 1294 -4154
+ Misses 9 0 -9
+ Partials 186 15 -171
Continue to review full report at Codecov.
|
aggarg
previously approved these changes
Aug 18, 2020
aggarg
approved these changes
Aug 18, 2020
muneebahmed10
approved these changes
Aug 18, 2020
| /** | ||
| * @brief Length of path to server certificate. | ||
| */ | ||
| #define ROOT_CA_CERT_PATH_LENGTH ( ( uint16_t ) ( sizeof( ROOT_CA_CERT_PATH ) - 1 ) ) |
There was a problem hiding this comment.
I assume this is an unused macro
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 27, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 28, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 31, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hygiene changes as follow-up of #1128
localhostdefault definition ofBROKER_ENDPOINTto avoid developer inconvencience of understanding demo failure when they don't have local Mosquitto broker setupBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.