Skip to content

Improve README.md docker instructions #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 4, 2020
Merged

Improve README.md docker instructions #1371

merged 7 commits into from
Nov 4, 2020

Conversation

sarenameas
Copy link
Contributor

  • Update ngrok instructions to be on separate lines.
  • Fix updating the mqtt_demo_plaintext server address after setting up the plaintext server.'
  • Use relative paths for links to files in this repo.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

sarenameas
sarenameas commented Nov 4, 2020
View reviewed changes
README.md
@@ -303,14 +303,14 @@ The following instructions have been tested on an Ubuntu 18.04 environment with
docker pull eclipse-mosquitto:latest
```

`BROKER_ENDPOINT` defined in `demos/mqtt/mqtt_demo_basic_tls/demo_config.h` can now be set to `localhost`.
Copy link
Contributor Author

@sarenameas sarenameas Nov 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrect or out of place

jainamt
jainamt previously approved these changes Nov 4, 2020
View reviewed changes
jainamt
jainamt previously approved these changes Nov 4, 2020
View reviewed changes
jainamt
jainamt previously approved these changes Nov 4, 2020
View reviewed changes
@sarenameas sarenameas merged commit af0cf05 into aws:master Nov 4, 2020
@sarenameas sarenameas deleted the readme branch November 4, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archigup archigup archigup approved these changes

+3 more reviewers

@aggarg aggarg aggarg approved these changes

@leegeth leegeth leegeth approved these changes

@jainamt jainamt jainamt left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarenameas @aggarg @jainamt @leegeth @archigup