Skip to content

Conversation

sbSteveK
Copy link
Contributor

@sbSteveK sbSteveK commented Apr 23, 2025

CI was failing due to a number of reasons:

actions/setup-java@v2 had its cache backend shut off on 4/15/2025 resulting in HTTP 422.
Updated them to [email protected] which bumps the dependency to @actions/cache v4.0.3. This also bumps the Node version used from 12 to 16 but that seems unavoidable if we continue to use setup-java.

v4 is also available but that bumps to Node 20 so we can stick with 3.14.0 for now.

Temurin 8 appears to not have support for macOS14 which was causing the osx-java-compat(8) to fail:
https://adoptium.net/supported-platforms/
For 8 on osx, we will use corretto for now. Both Temurin 8 and Corretto 8 are reported to end security maintenance in mid 2026 so we may need to revisit this at that point.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sbSteveK sbSteveK changed the title Ci check CI Fix Apr 23, 2025
Copy link
Contributor

@sfod sfod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved.
One question, though. Why

v4 is also available but that bumps to Node 20

is a problem for CI?

@sbSteveK
Copy link
Contributor Author

LGTM, approved. One question, though. Why

v4 is also available but that bumps to Node 20

is a problem for CI?

Not really but it feels bad to bump versions higher than we need to in case something breaks in the future that we may have caught.

@sbSteveK sbSteveK merged commit e4699c9 into main Apr 24, 2025
15 checks passed
@sbSteveK sbSteveK deleted the ci-check branch April 24, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants