Skip to content

refactor: use assert.PanicsWithValue #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023
Merged

refactor: use assert.PanicsWithValue #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions events/attributevalue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,25 +215,10 @@ func TestAccessWithWrongTypePanics(t *testing.T) {
var av DynamoDBAttributeValue
err := json.Unmarshal([]byte(testCase.input), &av)
assert.Nil(t, err)
// may use PanicsWithValue(expectedError) when it is available
assertPanicsWithValue(t, testCase.expectedError, func() { testCase.accessor(av) })
assert.PanicsWithValue(t, testCase.expectedError, func() { testCase.accessor(av) })
}
}

func assertPanicsWithValue(t *testing.T, expected error, action func()) {
defer func() {
r := recover()
if r == nil {
t.Errorf("Should have panicked")
}
if r != expected {
t.Errorf("should have panicked with value %v but panicked with value %v", expected, r)
}
}()

action()
}

func TestMarshalAndUnmarshalString(t *testing.T) {
const inputString = "INPUT STRING"
inputValue := NewStringAttribute(inputString)
Expand Down