Skip to content

Conversation

amalakar
Copy link

Issue: #575

Add otfMetadata in metadata for firehose kinesis response record to support table routing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

"metadata": {
"partitionKeys": {}
"partitionKeys": {},
"otfMetadata": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does Firehose handle metadata with empty strings? Will this cause an error? IE, if I want to transform but not route, what happens?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without knowing Firehose's behavior, it'd be prudent to add 'omitempty' to the new struct tag

const (
KinesisFirehoseOtfOperationInsert = "insert"
KinesisFirehoseOtfOperationUpdate = "update"
KinesisFirehoseOtfOperationDelete = "delete"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected type KinesisFirehoseOTFOperation string, like is done elsewhere for similar enum-likes in other events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants