Skip to content

Conversation

trivenay
Copy link
Contributor

Issue #, if available:
NA

Description of changes:
Raise all init errors in init instead of suppressing them until the fist invoke

Target (OCI, Managed Runtime, both):
Both

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@trivenay trivenay requested a review from briensea July 31, 2024 14:02

try:
if modname.split(".")[0] in sys.builtin_module_names:
fault = FaultException(
FaultException.BUILT_IN_MODULE_CONFLICT,
"Cannot use built-in module {} as a handler module".format(modname),
)
return make_fault_handler(fault)
raise fault
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetic: fault variable is not actually used, instead you could do

raise FaultException(...

@trivenay trivenay closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants