Skip to content

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Sep 12, 2025

Issues:

Addresses #849

Description of changes:

Add several common traits (Send, Sync, Clone, and AsRef<[u8]>) for signature:: and agreement:: ParsedPublicKey.

Testing:

Tests updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner September 12, 2025 14:15
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.36%. Comparing base (c358484) to head (3b37f82).
⚠️ Report is 253 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/signature.rs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   95.80%   92.36%   -3.44%     
==========================================
  Files          61       73      +12     
  Lines        8143     9634    +1491     
  Branches        0     9634    +9634     
==========================================
+ Hits         7801     8898    +1097     
- Misses        342      450     +108     
- Partials        0      286     +286     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth requested a review from skmcgrail September 12, 2025 15:00
Copy link

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this patch in my project and it allowed me to replace my UnparsedPublicKeys with ParsedPublicKeys. Everything works as expected. Thank you :)

I also briefly looked over the code (as a non-maintainer, so I have zero authority here obviously) and it looks good!

@justsmth justsmth merged commit ab1ab3d into aws:main Sep 15, 2025
564 of 570 checks passed
@justsmth justsmth deleted the traits-for-ParsedPublicKey branch September 15, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants