Skip to content

capture hash functionality #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: inject-hash-cpp-experiment
Choose a base branch
from

Conversation

prikhap
Copy link

@prikhap prikhap commented Aug 12, 2025

Description

This pull request implements a C++ version of capture_hash for AWS-LC's FIPS module integrity verification. The implementation now has a complete solution for handling FIPS integrity across all supported platforms (Linux, MacOS, and Windows) for a shared build. It also maintains compatibility with existing FIPS integrity verification workflow

Key Implementation Changes

Windows-specific implementation for capturing correct hash values
Integration with MSVC build process
Error handling and output parsing

Files Modified

tests/ci/run_capture_hash_cpp.bat: Test script for Windows
util/fipstools/inject_hash_cpp/capture_hash.cpp: Windows implementation
util/fipstools/inject_hash_cpp/CMakeLists.txt: Build configuration
crypto/CMakeLists.txt: Integration with AWS-LC build system

Testing

Command-line argument handling
Output parsing
Hash extraction
Integration with build process

@prikhap prikhap requested a review from a team as a code owner August 12, 2025 02:58
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#include <vector>
#include <sstream>
#include <iostream>
#include <io.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'io.h' file not found [clang-diagnostic-error]

#include <io.h>
         ^

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.75%. Comparing base (f97b00a) to head (e02e32a).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           inject-hash-cpp-experiment    #2606      +/-   ##
==============================================================
- Coverage                       78.76%   78.75%   -0.02%     
==============================================================
  Files                             642      642              
  Lines                          110242   110241       -1     
  Branches                        15602    15602              
==============================================================
- Hits                            86831    86816      -15     
- Misses                          22713    22728      +15     
+ Partials                          698      697       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prikhap prikhap force-pushed the inject-and-capture branch 3 times, most recently from 83ef50b to 98cdc0c Compare August 13, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants