checkout commits in s2n-bignum import.sh #2646
Open
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
==========================================
+ Coverage 78.81% 78.83% +0.01%
==========================================
Files 667 667
Lines 114088 114088
Branches 16063 16063
==========================================
+ Hits 89923 89940 +17
+ Misses 23390 23373 -17
Partials 775 775 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
third_party/s2n-bignum/import.sh
Outdated
| echo "Fetching repository ..." | ||
| git clone ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} ${TMP} --branch ${GITHUB_TARGET} --single-branch > /dev/null | ||
| GITHUB_COMMIT=$(cd ${TMP} >/dev/null; git rev-parse HEAD) | ||
| GITHUB_COMMIT=$(cd ${TMP} > /dev/null; git checkout ${COMMIT_HASH} > /dev/null; git rev-parse HEAD) |
There was a problem hiding this comment.
Suggestion: Follow the mlkem-native importer and only import the exact commit you care about. At the same time, remove distinction between GITHUB_TARGET and COMMIT_HASH:
git init >/dev/null
git remote add origin $GITHUB_SERVER_URL/$GITHUB_REPOSITORY >/dev/null
git fetch origin --depth 1 $GITHUB_SHA >/dev/null
git checkout FETCH_HEAD >/dev/null
|
@manastasova What's the status of this PR? Are you going to keep working on it, or should it be closed? |
Example usage: GITHUB_REPOSITORY=awslabs/s2n-bignum GITHUB_TARGET=main COMMIT_HASH=717b57a ./import.sh
manastasova
force-pushed
the
s2n-bignum_import_script
branch
from
1b3f308 to
6ca18fc
Compare
Short commit hashes are no longer supported to avoid fetch complexity
|
Thanks, @hanno-becker. I just updated the import file. |
skmcgrail
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for checking out specific commits in s2n-bignum import.sh
Example usage:
GITHUB_REPOSITORY=awslabs/s2n-bignum COMMIT_HASH=717b57a ./import.sh
Issues:
Addresses: Allow to choose s2n-bignum specific commit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.