Fix ternary operator in github workflow #2653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
previously approved these changes
Sep 3, 2025
|
checked that steps now have the correct name. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 663 663
Lines 113346 113346
Branches 15946 15947 +1
=======================================
+ Hits 89264 89270 +6
+ Misses 23304 23299 -5
+ Partials 778 777 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Sep 3, 2025
dkostic
approved these changes
Sep 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The constructed ternary:
A && B || Cequivalent toA ? B : C. In Github actionBmust evaluate to True for this to work. See actions/runner#409 (comment)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.