Increase SSLBuffer size to INT_MAX #2673
Merged
+88
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
fix-ssl-read-val
branch
from
eed3264 to
dfac1bc
Compare
skmcgrail
previously approved these changes
Sep 9, 2025
samuel40791765
force-pushed
the
fix-ssl-read-val
branch
from
dfac1bc to
c683a6e
Compare
samuel40791765
force-pushed
the
fix-ssl-read-val
branch
from
c683a6e to
0fd4dc8
Compare
skmcgrail
approved these changes
Sep 9, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
+ Coverage 78.79% 78.81% +0.02%
==========================================
Files 667 667
Lines 113982 114078 +96
Branches 16030 16046 +16
==========================================
+ Hits 89810 89914 +104
+ Misses 23397 23389 -8
Partials 775 775 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smittals2
approved these changes
Sep 9, 2025
skmcgrail
pushed a commit
to skmcgrail/aws-lc
that referenced
this pull request
Sep 10, 2025
Curl is setting a buffer size larger than the maximum buffer length that AWS-LC allows. `0x401e * 4` is inherently `65656`, which is larger than the allowed `65535` and AWS-LC directly uses the largest size available (`65535`) if the consuming application sets a value larger than that. This limitation's due to a buffer size we inherited from upstream. I've tested against the test that was failing for curl and the test seems to pass now (for all instances I've ran it). Running `pytest -n auto -v ./http/test_10_proxy.py::TestProxy::test_10_08_upload_seq_large -rA` had been failing 5/10 times prior to this change and it passes every time that I run it now. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 78ada21)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #2650
Description of changes:
Curl is setting a buffer size larger than the maximum buffer length that AWS-LC allows.
0x401e * 4is inherently65656, which is larger than the allowed65535and AWS-LC directly uses the largest size available (65535) if the consuming application sets a value larger than that. This limitation's due to a buffer size we inherited from upstream:aws-lc/ssl/ssl_buffer.cc
Lines 32 to 34 in 5a834ec
I've tested against the test that was failing for curl and the test seems to pass now (for all instances I've ran it). Running
pytest -n auto -v ./http/test_10_proxy.py::TestProxy::test_10_08_upload_seq_large -rAhad been failing 5/10 times prior to this change and it passes every time that I run it now.Call-outs:
N/A
Testing:
New serde tests and buffer limit test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.