Add EVP_PKEY_check and EVP_PKEY_public_check for KEMs #2709
+148
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
==========================================
- Coverage 78.82% 78.81% -0.02%
==========================================
Files 667 667
Lines 114077 114143 +66
Branches 16045 16052 +7
==========================================
+ Hits 89925 89960 +35
- Misses 23378 23409 +31
Partials 774 774 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Sep 24, 2025
Comment on lines
+322
to
+326
| // Check that at least the public key exists | ||
| if (key->public_key == NULL) { | ||
| OPENSSL_PUT_ERROR(EVP, EVP_R_NO_KEY_SET); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
NP: It's currently possible (although I wish it weren't) for the secret_key to be set but not the public_key. For those, this would always return an error.
justsmth
reviewed
Sep 24, 2025
Comment on lines
+333
to
+342
| if (ml_kem_512_check_pk(key->public_key) != 0) { | ||
| OPENSSL_PUT_ERROR(EVP, EVP_R_DECODE_ERROR); | ||
| return 0; | ||
| } | ||
| // Check secret key validity if present | ||
| if (key->secret_key != NULL && ml_kem_512_check_sk(key->secret_key) != 0) { | ||
| OPENSSL_PUT_ERROR(EVP, EVP_R_DECODE_ERROR); | ||
| return 0; | ||
| } | ||
| break; |
There was a problem hiding this comment.
We would also need a pair-consistency check, otherwise the secret and public keys might be unrelated. (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A - ML-KEM support.
Description of changes:
mlkem-native provides
pkandskcheck functions crypto_kem_check_pk and crypto_kem_check_sk that are namespaced toml_kem_{512/768/1024}_check_{pk/sk}. This PR hooks them up toEVP_PKEY_checkandEVP_PKEY_public_checkso we can call them onPKEYof typeKEM.Call-outs:
Due to the way the MLKEM multi-level build is compiled, we can't call
mlkem{512/768/1024}_check_skdirectly, so have to have those little wrapper functions incrypto/fipsmodule/ml_kem/ml_kem.c, as with other functions in that file.Testing:
KEM tests are modified to:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.