Add running pods (soon to be evicted) to webhook notifications #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imuqtadir
changed the title
|
Using the latest tag, with a webhook template of "Pods: {{ .Pods }}" the notification returns Pods: []. @imuqtadir does it function for you properly after merging the change? |
|
Yeah, this PR undo some of my changes #411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #359
Description of changes: Provide list of running pods as webhook notifications. This will be available as override to default webhook template.
Sample Webhook Template:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.