Skip to content

Implements IsCredentialsProvider for checking if a provider matches a target provider type. #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2022
Merged

Implements IsCredentialsProvider for checking if a provider matches a target provider type. #1890

merged 3 commits into from
Oct 21, 2022

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Oct 20, 2022 •
edited
Loading

Fixes #1797
Fixes #1174

@skmcgrail skmcgrail requested a review from a team as a code owner October 20, 2022 02:35
@skmcgrail skmcgrail force-pushed the isCredProvider branch 2 times, most recently from 3f68040 to 0fc6364 Compare October 20, 2022 16:18
jasdel
jasdel approved these changes Oct 20, 2022
View reviewed changes
@skmcgrail skmcgrail merged commit 1c05fb6 into aws:main Oct 21, 2022
@skmcgrail skmcgrail deleted the isCredProvider branch October 21, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

@isaiahvita isaiahvita isaiahvita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnonymusCredentials is not respected by S3 API Using aws.AnonymousCredentials{} in config fails to skip SignHTTPRequestMiddleware#HandleFinalize
3 participants
@skmcgrail @jasdel @isaiahvita