private/model/api: Fix API doc being generated with wrong value #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the SDK's generated API documentation for structure member being generated with the wrong documentation value when the member was included multiple times in the model doc-2.json file, but under different types. The SDK was not considering the member's type when associating documetation with the member. Only parent struct name and member names was being used. V2 Port of aws/aws-sdk-go#2748
skotambkar
reviewed
Aug 20, 2019
| * `private/model`: Handles empty map vs unset map behavior in send request ([#337](https://github.com/aws/aws-sdk-go-v2/pull/337)) | ||
| * Updates shape marshal model to handle the empty map vs nil map behavior. Also adds a test case to assert behavior when a user sends an empty map vs unset map. | ||
| * Fixes [#332](https://github.com/aws/aws-sdk-go-v2/issues/332) | ||
| * `private/model/api`: Fix API doc being generated with wrong value ([#359](https://github.com/aws/aws-sdk-go-v2/pull/359)) |
There was a problem hiding this comment.
Should we add reference to the v1 git issue or create and reference v2 git issue?
skotambkar
approved these changes
Aug 20, 2019
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Aug 22, 2019
Services === * Synced the V2 SDK with latest AWS service API definitions. * Fixes [aws#359](aws#359) SDK Features === SDK Enhancements === * `private/protocol`: Add support for TimestampFormat in protocols ([aws#358](aws#358)) * Adds support for the timestampForamt API model trait to the V2 SDK. The SDK will now generate API client parameters with the correct time format for APIs modeled with custom time stamp formats specified. * Fixes [aws#202](aws#202) * Fixes [aws#286](aws#286) * `aws`: Add example for custom HTTP client idle connection options ([aws#350](aws#350)) * Adds example to the SDK for configuring custom HTTP client idle connection keep alive options. SDK Bugs === * `private/model/api`: Fix API doc being generated with wrong value ([aws#359](aws#359)) * Fixes the SDK's generated API documentation for structure member being generated with the wrong documentation value when the member was included multiple times in the model doc-2.json file, but under different types. * V2 port of to v1 [aws/aws-sdk-go#2748](aws/aws-sdk-go#2748) * `aws/ec2rolecreds`: Fix security creds path to include trailing slash ([aws#356](aws#356)) * Fixes the iamSecurityCredsPath var to include a trailing slash preventing redirects when making requests to the EC2 Instance Metadata service. * Fixes [aws#351](aws#351) * `service/dynamodb/expression`: Improved reporting of bad key conditions ([aws#360](aws#360)) * Improved error reporting when invalid key conditions are constructed using KeyConditionBuilder
jasdel
added a commit
that referenced
this pull request
Aug 23, 2019
Services === * Synced the V2 SDK with latest AWS service API definitions. * Fixes [#359](#359) SDK Features === SDK Enhancements === * `private/protocol`: Add support for TimestampFormat in protocols ([#358](#358)) * Adds support for the timestampForamt API model trait to the V2 SDK. The SDK will now generate API client parameters with the correct time format for APIs modeled with custom time stamp formats specified. * Fixes [#202](#202) * Fixes [#286](#286) * `aws`: Add example for custom HTTP client idle connection options ([#350](#350)) * Adds example to the SDK for configuring custom HTTP client idle connection keep alive options. SDK Bugs === * `private/model/api`: Fix API doc being generated with wrong value ([#359](#359)) * Fixes the SDK's generated API documentation for structure member being generated with the wrong documentation value when the member was included multiple times in the model doc-2.json file, but under different types. * V2 port of to v1 [aws/aws-sdk-go#2748](aws/aws-sdk-go#2748) * `aws/ec2rolecreds`: Fix security creds path to include trailing slash ([#356](#356)) * Fixes the iamSecurityCredsPath var to include a trailing slash preventing redirects when making requests to the EC2 Instance Metadata service. * Fixes [#351](#351) * `service/dynamodb/expression`: Improved reporting of bad key conditions ([#360](#360)) * Improved error reporting when invalid key conditions are constructed using KeyConditionBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK's generated API documentation for structure member being generated with the wrong documentation value when the member was included multiple times in the model doc-2.json file, but under different types.
The SDK was not considering the member's type when associating documentation with the member. Only parent struct name and member names was being used.
V2 Port of aws/aws-sdk-go#2748