Skip to content

Open up BlockingOutputStreamAsyncRequestBody #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
djchapm opened this issue Jun 20, 2023 · 3 comments
Closed
2 tasks

Open up BlockingOutputStreamAsyncRequestBody #4119

djchapm opened this issue Jun 20, 2023 · 3 comments
Labels
feature-request A feature should be added or improved.

Comments

@djchapm
Copy link

djchapm commented Jun 20, 2023

Describe the feature

For streaming uploads it is very handy to be able to use an implementation of an OutputStream. One already exists but access to it is blocked as package-private in AsyncRequestBody.forBlockingInput/OutputStream. This would work well for clients attempting to stream data to S3 Asynchronously using TransferManager with UploadRequest requestBody equal to this OutputStream implementation.

Use Case

Asynchronous Streaming Uploads to S3.

Proposed Solution

make public.

Other Information

Example usage can be found in example I uploaded to awslabs/aws-c-s3#317

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.20.79

JDK version used

17

Operating System and version

Darwin US10MAC44VWYPKH 22.5.0 Darwin Kernel Version 22.5.0: Mon Apr 24 20:52:24 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T6000 arm64 arm Darwin

@djchapm djchapm added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 20, 2023
@millems
Copy link
Contributor

millems commented Jun 20, 2023

AsyncRequestBody.forBlockingOutputStream and AsyncRequestBody.forBlockingInputStream are supposed to be the public ways of creating this. Which part specifically is package private that you wanted opened up?

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Jun 20, 2023
@djchapm
Copy link
Author

djchapm commented Jun 20, 2023

Ugg My bad - I was down in the weeds too much and didn't see it was already open. Sorry!

@djchapm djchapm closed this as completed Jun 20, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants