Extract common AuthSchemeInterceptor logic into a base class #4146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@millems pointed out correctly that this will couple the base class in core with generated classes in service modules which makes it harder to maintain. Discarding this. |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jul 23, 2025
…e17233d84 Pull request: release <- staging/7a70241c-b036-4526-bd31-48be17233d84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AuthSchemeInterceptor has service specific and service agnostic logic. Moving the service agnostic logic into a base class in
sdk-core, so only service specific parts need to be code generated.Modifications
Extract common AuthSchemeInterceptor logic into a base class
Testing
AwsCertificateManagerIntegrationTestandCodeCatalystIntegrationTestrun successfully.