Disable Client based retries and define httpcore5 httpclient5 in .brazil.json #6191
Conversation
… is implementation of HttpClientConnectionManager
…ring content reference to avoid multiple ContentStreamProvider.newStream() calls that cause IOException when retrying requests with non-resettable streams
… Apache 4.x doesnot suports this
…e is value is set to 0 since 0 is treated as Infinite timeToLive in Sdk and Apache 4.x but treated as immediate closeConnection in apache 5.x
…o define Apache5 dependencies in .brazil.json
joviegas
force-pushed
the
joviegas/apache-5-achitecture-test-fix
branch
from
b19ead9 to
9431959
Compare
| @@ -218,6 +221,48 @@ public void testCustomTlsTrustManagerAndTrustAllFails() throws Exception { | |||
| assertThatThrownBy(() -> createSdkHttpClient(httpClientOptions)).isInstanceOf(IllegalArgumentException.class); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Adding test cases in SdkHttpClientTestSuite makes sure that all the other SDK clients gets testes since this class is extended by other HTTP clients too.
There was a problem hiding this comment.
Can we add it in async test suite as well?
| @@ -218,6 +221,48 @@ public void testCustomTlsTrustManagerAndTrustAllFails() throws Exception { | |||
| assertThatThrownBy(() -> createSdkHttpClient(httpClientOptions)).isInstanceOf(IllegalArgumentException.class); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Can we add it in async test suite as well?
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Motivation and Context
Modifications
Testing
License