Add 'stripKeyPrefix' option to TransferManager's downloadDirectory method #1322
Conversation
…dDirectory method.
| */ | ||
| public MultipleFileDownload downloadDirectory(String bucketName, String keyPrefix, File destinationDirectory, | ||
| boolean resumeOnRetry, KeyFilter filter) { | ||
| boolean resumeOnRetry, KeyFilter filter, boolean stripKeyPrefix) { |
There was a problem hiding this comment.
You never use this flag to strip the key prefix from the object key 😕
There was a problem hiding this comment.
Oops that's embarrassing! That's what I get for re-doing my changes in a more pull request worthy way...
Thanks, I pushed the actual functionality.
|
There a reason this wasn't merged? Be nice to have this option rather than downloading and having to move things to correct them subsequently. |
|
Sorry about the delay on this. Can you share some test code for this functionality? We'd like to import it to our test suite before we merge this change. |
millems
added
closing-soon
|
It looks like this PR hasn’t been active in longer than a week. In the absence of more information, we will be closing this PR soon. Please add a comment to prevent automatic closure, or if the PR is already closed please feel free to open a new one. |
github-actions
bot
added
closing-soon
Added an option to strip key prefixes to change downloadDirectory method behaviour without breaking backwards compatibility.
See #1321