@aws-sdk/client-sts AWSSDKSignatureV4 miss implementation

[glitchedslimy]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

Seems like while using the client STS SDK implementation the method for constructing the AWS SDK Signature V4 with the @aws-sdk/core gives a TypeError.

This type error seems to be inside the shared runtime, runtimeConfig and httpAuthSchemeProvider.

The current method of implementation: signer: new core_1.AwsSdkSigV4Signer(),

Has changed to: new core_1.AWSSDKSigV4Signer(), and core_1.resolveAwsSdkSigV4Config has change to core_1.resolveAWSSDKSigV4Config.

Hence giving: TypeError: core_1.AwsSdkSigV4Signer is not a constructor.

Regression Issue

• Select this option if this issue appears to be a regression.

SDK version number

@aws-sdk/client-sts@3.795.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v18.17.1

Reproduction Steps

1. Implement the package through NPM, Yarn or PNPM.
2. Try to make a normal implementation of role assumption inside the STS SDK.
3. Execute the file / script and the error should appear.

Observed Behavior

TypeError: core_1.AwsSdkSigV4Signer is not a constructor
at getRuntimeConfig (/home/slimy/code/project/node_modules/@aws-sdk/client-sts/dist-cjs/runtimeConfig.shared.js:25:25)
at getRuntimeConfig (/home/slimy/code/project//node_modules/@aws-sdk/client-sts/dist-cjs/runtimeConfig.js:25:76)
at new STSClient (/home/slimy/code/project/node_modules/@aws-sdk/client-sts/dist-cjs/STSClient.js:22:64)
at /home/slimy/code/project/dist/apps/collect-data/webpack:/src/main.ts:7:19
at/home/slimy/code/project/dist/apps/collect-data/main.js:178:3
at Object. (/home/slimy/code/project/dist/apps/collect-data/main.js:183:12)
at Module._compile (node:internal/modules/cjs/loader:1256:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
at Module.load (node:internal/modules/cjs/loader:1119:32)
at Function.Module._load (node:internal/modules/cjs/loader:960:12)

Expected Behavior

I expected to receive a normal role assumption through the STS SDK.

Possible Solution

Maybe a solution could be changing the current methods from the ones that has been updated to.

Additional Information/Context

No response

[glitchedslimy]

The implementation:

/**
 * @internal
 * @deprecated renamed to {@link AwsSdkSigV4Signer}
 */
export const AWSSDKSigV4Signer = AwsSdkSigV4Signer;

Inside the file AwsSdkSigV4Signer.ts.

Seems to be taken in count while the actual implementation of exporting the const directly it isn't.

[zshzbh]

The AwsSdkSigV4Signer in this file is marked as internal, which is only for internal usage and you shouldn't use this from core.

/**
 * @internal
 * @deprecated renamed to {@link AwsSdkSigV4Signer}
 */
export const AWSSDKSigV4Signer = AwsSdkSigV4Signer; 

https://github.com/aws/aws-sdk-js-v3/blob/main/packages/core/src/submodules/httpAuthSchemes/aws_sdk/AwsSdkSigV4Signer.ts#L154-L157C14

[zshzbh]

@aws-sdk/signature-v4 has moved to @smithy/signature-v4

Please use @smithy/signature-v4 - https://www.npmjs.com/package/@smithy/signature-v4 , https://github.com/smithy-lang/smithy-typescript/tree/main/packages/signature-v4

import { SignatureV4 } from "@smithy/signature-v4";

const signerInit = {
  service: "foo",
  region: "us-bar-1",
  sha256: Sha256,
  credentials: {
    accessKeyId: "foo",
    secretAccessKey: "bar",
  },
};

const signer = new SignatureV4(signerInit);

[glitchedslimy]

But this error comes from the compiled version of the SDK (CJS), that goes into that implementation from the core and gives that type error when using the STS Client from the oficial SDK package.

So Im not exactly sure about what you mean by using the Signature-v4 from smithy.

Should the signature v4 used outside the client, or should be already implemented inside the SDK source?