Skip to content

chore: rename ExponentialBackOff to Standard for RetryStrategy #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020
Merged

chore: rename ExponentialBackOff to Standard for RetryStrategy #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/middleware-retry/src/configurations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { RetryStrategy } from "@aws-sdk/types";
import { ExponentialBackOffStrategy } from "./defaultStrategy";
import { StandardRetryStrategy } from "./defaultStrategy";

export interface RetryInputConfig {
/**
Expand All @@ -11,18 +11,19 @@ export interface RetryInputConfig {
*/
retryStrategy?: RetryStrategy;
}

export interface RetryResolvedConfig {
maxAttempts: number;
retryStrategy: RetryStrategy;
}

export function resolveRetryConfig<T>(
input: T & RetryInputConfig
): T & RetryResolvedConfig {
const maxAttempts = input.maxAttempts === undefined ? 3 : input.maxAttempts;
return {
...input,
maxAttempts,
retryStrategy:
input.retryStrategy || new ExponentialBackOffStrategy(maxAttempts)
retryStrategy: input.retryStrategy || new StandardRetryStrategy(maxAttempts)
};
}
2 changes: 1 addition & 1 deletion packages/middleware-retry/src/defaultStrategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface DelayDecider {
(delayBase: number, attempts: number): number;
}

export class ExponentialBackOffStrategy implements RetryStrategy {
export class StandardRetryStrategy implements RetryStrategy {
constructor(
public readonly maxAttempts: number,
private retryDecider: RetryDecider = defaultRetryDecider,
Expand Down
4 changes: 2 additions & 2 deletions packages/middleware-retry/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
import { retryMiddleware } from "./retryMiddleware";
import { resolveRetryConfig } from "./configurations";
import * as delayDeciderModule from "./delayDecider";
import { ExponentialBackOffStrategy, RetryDecider } from "./defaultStrategy";
import { StandardRetryStrategy, RetryDecider } from "./defaultStrategy";
import { HttpRequest } from "@aws-sdk/protocol-http";
import { SdkError } from "@aws-sdk/smithy-client";

Expand Down Expand Up @@ -75,7 +75,7 @@ describe("retryMiddleware", () => {
"defaultDelayDecider"
);
const retryDecider: RetryDecider = (error: SdkError) => true;
const strategy = new ExponentialBackOffStrategy(maxAttempts, retryDecider);
const strategy = new StandardRetryStrategy(maxAttempts, retryDecider);
const retryHandler = retryMiddleware({
maxAttempts,
retryStrategy: strategy
Expand Down