Skip to content

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 6, 2022

Issue

Noticed in build failures while using root TSConfig in clients at #3151

Description

Removes unnecessary exclude from tsconfig in md5-js

Testing

Verified that build is successful

$ md5-js> yarn build
yarn run v1.22.17
$ yarn build:cjs && yarn build:es && yarn build:types
$ tsc -p tsconfig.cjs.json
$ tsc -p tsconfig.es.json
$ tsc -p tsconfig.types.json
Done in 4.24s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 6, 2022 23:26
@trivikr trivikr merged commit 6f50571 into aws:main Jan 6, 2022
@trivikr trivikr deleted the md5-js-unnecessary-exclude branch January 6, 2022 23:46
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants