Skip to content

duplicate IValidation definition #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasSteinbach opened this issue Jun 3, 2022 · 0 comments · Fixed by #1091
Closed

duplicate IValidation definition #1095

ThomasSteinbach opened this issue Jun 3, 2022 · 0 comments · Fixed by #1091

Comments

@ThomasSteinbach
Copy link
Contributor

The definition of the IValidation interface exists twice in the constructs.ts. The code is 100% identical. I think one occurence could be deleted.

I fixed this in #1091
@ThomasSteinbach ThomasSteinbach mentioned this issue Jun 3, 2022
Merged
@mergify mergify bot closed this as completed in #1091 Jun 14, 2022
mergify bot pushed a commit that referenced this issue Jun 14, 2022
@ThomasSteinbach
chore: remove duplicated IValidation definition (#1091)
f8edef8 
The interface `IValidation` was defined twice in this code. I delete the duplicate, whose lines were to 100% identical to the ones from line 480.

Fixes #1095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove duplicated IValidation definition ThomasSteinbach/constructs
1 participant
@ThomasSteinbach