chore: [Foss] Sync public: Add retry and logging for dlq/http/cors flaky requests #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingkun2020
changed the title
jfuss
suggested changes
Jun 29, 2022
| from unittest.case import skipIf | ||
|
|
||
| from tenacity import stop_after_attempt, retry_if_exception_type, after_log, wait_exponential, retry, wait_random |
There was a problem hiding this comment.
Where is tenacity coming from?
There was a problem hiding this comment.
Tenacity is a retry library we used in integration tests and it has Apache 2.0 liciense.
Closed
11 tasks
mingkun2020
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2428 +/- ##
===========================================
+ Coverage 93.58% 94.43% +0.85%
===========================================
Files 90 98 +8
Lines 6124 7266 +1142
Branches 1260 1511 +251
===========================================
+ Hits 5731 6862 +1131
- Misses 183 195 +12
+ Partials 210 209 -1
Continue to review full report at Codecov.
|
mndeveci
reviewed
Jun 30, 2022
mndeveci
approved these changes
Jun 30, 2022
qingchm
approved these changes
Jul 7, 2022
jfuss
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
add retry and logging for dlq/http/cors flaky requests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.