Skip to content

chore: Update how we download CFN documentation #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 7, 2023

Issue #, if available

Description of changes

https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cfnspec/README.md
CDK moved where the schema files are stored. And it's now stored as Git LFS. We have to update how we download the file.

Description of how you validated changes

make schema-all works locally.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ marked this pull request as ready for review November 7, 2023 00:41
@GavinZZ GavinZZ requested a review from a team as a code owner November 7, 2023 00:41
@GavinZZ GavinZZ merged commit 71a0219 into aws:develop Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants