Skip to content

updated packages version & reverting versioned bucket and test cases #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 13, 2024
Merged

Conversation

adadouche
Copy link
Contributor

Issue #, if available:

Description of changes:

  • updated packages version
  • reverting versioned bucket and test cases

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thomas-roos
Copy link
Contributor

Hi, why reverting?

@adadouche
Copy link
Contributor Author

I found a glitch after redeploying the pipelines, pipelines absolutely require versioning on the source buckets.
I initially disabled only tests and only activated the versioning where needed but felt it was a little dirty
I couldn't find a way to update the test to check for a specific property on a specific resource types (VersionConfiguration : Enabled for S3::Bucket resource type) so decided to revert the previous changes to avoid deployment problems

thomas-roos
thomas-roos previously approved these changes Dec 12, 2024
Copy link
Contributor

@thomas-roos thomas-roos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thomas-roos
Copy link
Contributor

Can you have a look into the failing tests?

@adadouche adadouche marked this pull request as draft December 13, 2024 13:12
@adadouche adadouche marked this pull request as ready for review December 13, 2024 14:24
@thomas-roos thomas-roos merged commit cd39599 into aws4embeddedlinux:main Dec 13, 2024
5 checks passed
@thomas-roos
Copy link
Contributor

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants