Resolving Windows file encoding issues #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added call to powershell.exe to ensure this works with regular cmd windows too. |
|
Thanks for the contribution! Merging. |
ghost
closed this
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-cdk#15066
Description of changes:
Windows
>redirect operator (an alias for the PowerShell cmdlet 'Out-File') defaults to UTF-16LE encoding as per the documentation.The CDK expects templates fed to it with the
--templateCLI flag to be UTF-8 encoded, so grabbing the template according to the current docs will technically download the template file but prevent you from doing anything further with it using the CDK.Proposing we add separation for Mac/Linux and Windows so that we can explicitly enforce utf-8 encoding for the Windows Out-File cmdlet.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.