Fix error in Java MyPipelineStack #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview
- For Java projects there is no `package.json` to install AWS-CDK. This
causes errors when attempting to deploy the pipeline as the `npm ci`
step depends on this file.
- Fixed the commands to `Arrays.asList("npm install -g aws-sdk", "cdk
synth")` to correct this behavior.
Testing
- Created new pipeline following the updated steps and was successful in
pipeline creation and deployment.
Relevant links
- https://docs.aws.amazon.com/cdk/api/latest/docs/pipelines-readme.html
- In the `Synth and sources` section this behavior is described.
|
Yes, good catch. The CDK Toolkit isn't installed in Java projects (or Python, or C#). Will fix that in the other two languages too. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
package.jsonto install AWS-CDK. This causes errors when attempting to deploy the pipeline as thenpm cistep depends on this file.Arrays.asList("npm install -g aws-sdk", "cdk synth")to correct this behavior.Testing
Relevant links
Issue #, if available: n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.