Skip to content

Fetch lock item from notMyLocks only once #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fetch lock item from notMyLocks only once #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/main/java/com/amazonaws/services/dynamodbv2/AmazonDynamoDBLockClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,15 +474,13 @@ public LockItem acquireLock(final AcquireLockOptions options) throws LockNotGran
String id = existingLock.get().getUniqueIdentifier();
// Let's check to see if this existingLock expired based on old data we cached.
// Or cache it if we haven't seen this recordVersion before.
LockItem cachedLock = notMyLocks.get(id);
boolean isReallyExpired = false;
if (notMyLocks.containsKey(id) &&
notMyLocks.get(id).getRecordVersionNumber()
.equals(existingLock.get().getRecordVersionNumber())) {

isReallyExpired = notMyLocks.get(id).isExpired();
if (cachedLock != null && cachedLock.getRecordVersionNumber().equals(existingLock.get().getRecordVersionNumber())) {
isReallyExpired = cachedLock.isExpired();
if (isReallyExpired) {
// short circuit the waiting that we normally do.
lockTryingToBeAcquired = notMyLocks.get(id);
lockTryingToBeAcquired = cachedLock;
}
} else {
notMyLocks.put(id, existingLock.get());
Expand Down