Add support for fencing via sequence ids #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Apr 17, 2018
| // If we're tracking sequence IDs, initialize or increment the current value. | ||
| Optional<Long> sequenceId = Optional.empty(); | ||
| if (trackSequenceIds) { | ||
| sequenceId = existingLock.flatMap(value -> value.getSequenceId()); |
There was a problem hiding this comment.
How about:
sequenceId = Optional.of(existingLock.flatMap(value -> value.getSequenceId()).orElse(0L) + 1)Motivation:
- make it clear that you fallback to
0Lwhen there was no lock / seq. id - the step (
+1) is also clearly defined
bsideup
reviewed
Apr 17, 2018
| final boolean deleteLockOnRelease = options.getDeleteLockOnRelease(); | ||
| final boolean deleteLockOnRelease; | ||
| if (this.trackSequenceIds) { | ||
| if (options.getDeleteLockOnRelease().isPresent() && options.getDeleteLockOnRelease().get()) { |
There was a problem hiding this comment.
The functional police is here 👮 😄
if (options.getDeleteLockOnRelease().orElse(false)) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1; I finally had time to put together a pull request. Contributed under the terms of the Amazon Software License.