Skip to content

chore: stable fmt and clippy, set MSRV #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2021
Merged

chore: stable fmt and clippy, set MSRV #383

merged 1 commit into from
Dec 24, 2021

Conversation

nmoutschen
Copy link
Contributor

@nmoutschen nmoutschen commented Dec 18, 2021 •
edited
Loading

Issue #, if available: #380

Description of changes:

  • Set MSRV to 1.54.0
  • GitHub actions: Use stable for fmt and clippy
  • GitHub actions: add build for MSRV
  • GitHub actions: remove exclusions (will re-add them if any fail)
  • Change PhantomData abbreviation (that abbreviation has another meaning in French)
  • Add MSRV, security disclosure, and license to README file.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@realtimetodie realtimetodie mentioned this pull request Dec 18, 2021
Merged
2 tasks
calavera
calavera approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the two crates that I added

coltonweaver
coltonweaver approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@coltonweaver coltonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this :)

@coltonweaver coltonweaver merged commit 3c3a567 into master Dec 24, 2021
@nmoutschen nmoutschen deleted the ci-msrv branch February 1, 2022 08:27
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@calavera calavera calavera approved these changes

@coltonweaver coltonweaver coltonweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmoutschen @calavera @coltonweaver