Fix double cookie header for Lambda Function URL requests #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
approved these changes
Jan 12, 2023
THOUSAND-SKY
added a commit
to THOUSAND-SKY/remix-aws
that referenced
this pull request
Jan 7, 2024
Function URLs get cookies twice, in headers and the `cookies` array, which was causing them to duplicate. Ref: awslabs/aws-lambda-rust-runtime#586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
awslabs/aws-lambda-web-adapter/issues/121
Lambda Function URL requests include cookie in both
cookiesandheaders.cookieobjects. This causes lambda-http to duplicate cookie headers in the requests.Description of changes:
Replace
headers.append()withheaders.insert(). This fixes the issue.By submitting this pull request