Skip to content

Conversation

halx99
Copy link
Collaborator

@halx99 halx99 commented Aug 27, 2025

Describe your changes

Finally: The clang-format lint action in dev/v3 branch support lint_mode: check_only, create_pr, auto_commit, and every pull request is check_only

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@halx99 halx99 added this to the 3.0.0 milestone Aug 27, 2025
@halx99 halx99 added the enhancement New feature or request label Aug 27, 2025
@halx99 halx99 mentioned this pull request Aug 27, 2025
42 tasks
@paulocoutinhox
Copy link
Contributor

I think that inplace need be False, since the CI only will check if it is formatted and fail. The inplace will change files.

@aismann aismann self-requested a review August 27, 2025 20:51
@aismann
Copy link
Contributor

aismann commented Aug 27, 2025

Running cpp-tests (Windows works!)
Looked on some diffs ( I like the new code style, same look and "feel" on all Axmol source files)

Copy link
Contributor

@aismann aismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@halx99
Copy link
Collaborator Author

halx99 commented Aug 28, 2025

I think that inplace need be False, since the CI only will check if it is formatted and fail. The inplace will change files.

I change to lint only for PR, the clang-format lint action also support auto commit changes when trigger manually

@halx99 halx99 merged commit f0b258f into dev/v3 Aug 28, 2025
15 of 17 checks passed
@halx99 halx99 deleted the pr-clang-format branch August 28, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants