Skip to content

Fix pdf build issue #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2022
Merged

Fix pdf build issue #653

merged 2 commits into from
Jul 15, 2022

Conversation

sunny4381
Copy link
Contributor

No description provided.

@sunny4381 sunny4381 mentioned this pull request Sep 4, 2021
Open
linco95
linco95 approved these changes Sep 12, 2021
View reviewed changes
Copy link

@linco95 linco95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to be able to get the ebook build running again, so I can read this book easier!

@mayrhofer-simon
Copy link

Is it working again

@sunny4381
Copy link
Contributor Author

@mayrhofer-simon Yeah, you can see how it work in my repo: https://github.com/sunny4381/typescript-book/actions/runs/1200571871

@Eazash
Copy link

Eazash commented Oct 10, 2021

I believe it's now safe to also remove line 18, sudo apt update

@ivanbozhkov
Copy link

Can someone merge this, please?

@basarat basarat merged commit e43c5ce into basarat:master Jul 15, 2022
@basarat basarat mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linco95 linco95 linco95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sunny4381 @mayrhofer-simon @Eazash @ivanbozhkov @linco95 @basarat