Skip to content

Add fixture functions to basilisp.test #980 #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2024
Merged

Add fixture functions to basilisp.test #980 #1067

merged 2 commits into from
Sep 22, 2024

Conversation

mitch-kyle
Copy link
Contributor

I've separated out the test fixture functions from #1044 for #980

chrisrink10
chrisrink10 reviewed Sep 21, 2024
View reviewed changes
Copy link
Member

@chrisrink10 chrisrink10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out into a separate PR. This looks good to me. I just had 2 minor comments.

@chrisrink10 chrisrink10 merged commit 1fe7330 into basilisp-lang:main Sep 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrink10 chrisrink10 chrisrink10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitch-kyle @chrisrink10