Skip to content

Improve the state of Python type hints in basilisp.lang.compiler.* #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

chrisrink10
Copy link
Member

@chrisrink10 chrisrink10 commented Jan 4, 2024

Add typing_extensions to take advantage of Concatenate and ParamSpec across all supported versions of Python, allowing more correct type hints primarily targeting the compiler.

@chrisrink10 chrisrink10 force-pushed the feature/improve-type-hints branch 2 times, most recently from 6fdb9a9 to 1dff6e3 Compare January 7, 2024 20:31
chrisrink10 added a commit that referenced this pull request Jan 9, 2024
Second attempt to pare down the failing PyPy build for #784
@chrisrink10 chrisrink10 force-pushed the feature/improve-type-hints branch from 1dff6e3 to ceb6b02 Compare January 9, 2024 14:21
@chrisrink10 chrisrink10 force-pushed the feature/improve-type-hints branch from 6e89746 to caa615b Compare January 9, 2024 16:17
@chrisrink10 chrisrink10 changed the title Improve the state of Python type hints in basilisp.lang.* Improve the state of Python type hints in basilisp.lang.compiler.* Jan 9, 2024
@chrisrink10 chrisrink10 marked this pull request as ready for review January 9, 2024 17:45
@chrisrink10 chrisrink10 merged commit bb0e011 into main Jan 9, 2024
@chrisrink10 chrisrink10 deleted the feature/improve-type-hints branch January 9, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant