Skip to content

revert: change default bootstrap back to system_python #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

revert: change default bootstrap back to system_python #2968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
828cbe4
revert: change default bootstrap back to system_python
rickeylev Jun 11, 2025
157478d
revert changlog and docs
rickeylev Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,6 @@ END_UNRELEASED_TEMPLATE
{#v0-0-0-changed}
### Changed

* If using the (deprecated) autodetecting/runtime_env toolchain, then the Python
version specified at build-time *must* match the Python version used at
runtime (the {obj}`--@rules_python//python/config_settings:python_version`
flag and the {attr}`python_version` attribute control the build-time version
for a target). If they don't match, dependencies won't be importable. (Such a
misconfiguration was unlikely to work to begin with; this is called out as an
FYI).
* (rules) {obj}`--bootstrap_impl=script` is the default for non-Windows.
* (rules) On Windows, {obj}`--bootstrap_impl=system_python` is forced. This
allows setting `--bootstrap_impl=script` in bazelrc for mixed-platform
environments.
Expand Down
11 changes: 1 addition & 10 deletions docs/api/rules_python/python/config_settings/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,8 @@ Values:
::::{bzl:flag} bootstrap_impl
Determine how programs implement their startup process.

The default for this depends on the platform:
* Windows: `system_python` (**always** used)
* Other: `script`

Values:
* `system_python`: Use a bootstrap that requires a system Python available
* `system_python`: (default) Use a bootstrap that requires a system Python available
in order to start programs. This requires
{obj}`PyRuntimeInfo.bootstrap_template` to be a Python program.
* `script`: Use a bootstrap that uses an arbitrary executable script (usually a
Expand All @@ -273,11 +269,6 @@ instead.
:::{versionadded} 0.33.0
:::

:::{versionchanged} VERSION_NEXT_FEATURE
* The default for non-Windows changed from `system_python` to `script`.
* On Windows, the value is forced to `system_python`.
:::

::::

::::{bzl:flag} current_config
Expand Down
2 changes: 1 addition & 1 deletion python/config_settings/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ string_flag(

rp_string_flag(
name = "bootstrap_impl",
build_setting_default = BootstrapImplFlag.SCRIPT,
build_setting_default = BootstrapImplFlag.SYSTEM_PYTHON,
override = select({
# Windows doesn't yet support bootstrap=script, so force disable it
":_is_windows": BootstrapImplFlag.SYSTEM_PYTHON,
Expand Down