Skip to content

Catch Throwable in ExtraProtobufGenerator #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Catch Throwable in ExtraProtobufGenerator #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/src/main/scala/scalarules/test/extra_protobuf_generator/ExtraProtobufGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ object ExtraProtobufGenerator extends ProtocCodeGenerator {
handleCodeGeneratorRequest(request).toByteArray
}

def handleCodeGeneratorRequest(request: CodeGeneratorRequest): CodeGeneratorResponse = {
def handleCodeGeneratorRequest(request: CodeGeneratorRequest): CodeGeneratorResponse = {
val b = CodeGeneratorResponse.newBuilder
ProtobufGenerator.parseParameters(request.getParameter) match {
case Right(params) =>
Expand All @@ -73,6 +73,13 @@ object ExtraProtobufGenerator extends ProtocCodeGenerator {
} catch {
case e: GeneratorException =>
b.setError(e.message)
case e: Throwable =>
// Yes, we want to catch _all_ errors and send them back to the
// requestor. Otherwise uncaught errors will cause the generator to
// die and the worker invoking it to hang.
val stackStream = new java.io.ByteArrayOutputStream
e.printStackTrace(new java.io.PrintStream(stackStream))
b.setError(stackStream.toString())
}
case Left(error) =>
b.setError(error)
Expand Down